Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] Not all workflow outputs have a UUID #7258

Merged

Conversation

@mvdbeek
Copy link
Member

mvdbeek commented Jan 23, 2019

(Majorly!) Broken in #7227

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Jan 23, 2019

Was it failing with KeyError?

Can either data_output['uuid'] or workflow_output['uuid'] be '' or None ?

@mvdbeek

This comment has been minimized.

Copy link
Member Author

mvdbeek commented Jan 23, 2019

Can either data_output['uuid'] or workflow_output['uuid'] be '' or None ?

Yes, good point!

@mvdbeek

This comment has been minimized.

Copy link
Member Author

mvdbeek commented Jan 23, 2019

(

uuid=str(workflow_output.uuid) if workflow_output.uuid is not None else None,
)

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Jan 23, 2019

Which means that:

data_output.get('uuid', object()) == workflow_output.get('uuid', object())

can become:

None == None

which is True.

@mvdbeek

This comment has been minimized.

Copy link
Member Author

mvdbeek commented Jan 23, 2019

Thanks @nsoranzo, I think the last commit should fix that.

@mvdbeek mvdbeek force-pushed the mvdbeek:fix_workflow_uuid_access branch from 23c8f3b to 5ae49c1 Jan 24, 2019
@mvdbeek mvdbeek force-pushed the mvdbeek:fix_workflow_uuid_access branch from 5ae49c1 to f2a454c Jan 24, 2019
@nsoranzo nsoranzo added this to the 19.01 milestone Jan 24, 2019
@nsoranzo nsoranzo merged commit 1a4c1ec into galaxyproject:release_18.09 Jan 24, 2019
6 checks passed
6 checks passed
api test Build finished. 432 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 189 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 123 tests run, 10 skipped, 0 failed.
Details
selenium test Build finished. 146 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@nsoranzo nsoranzo deleted the mvdbeek:fix_workflow_uuid_access branch Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.