Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overlapping tooltip from dropdown button in library toolbar #7321

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@guerler
Copy link
Contributor

commented Feb 7, 2019

Having a tooltip in addition to a dropdown with title+subtitle is somewhat redundant and leads in this case to an overlap for auto-positioned tooltips.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Thanks for the fast fix @guerler !

@martenson

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Ideally our tests wouldn't fail on this, but the tooltips are notoriously problematic when hovered over so I can see this as a good change even though it removes usage help.

@martenson martenson merged commit 09bca89 into galaxyproject:dev Feb 8, 2019

6 checks passed

api test Build finished. 450 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 195 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 285 tests run, 12 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.