Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate api-based Toolshed interface in Admin panel #7402

Merged
merged 15 commits into from Jul 10, 2019

Conversation

@guerler
Copy link
Contributor

guerler commented Feb 22, 2019

This PR activates the new api-based Toolshed installer in the Galaxy's admin panel. This is the first step to properly branch the Toolshed and Galaxy repositories, so that they can maintained individually.

@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Feb 22, 2019

I really appreciate a lot that we do this, but is somebody then going to dedicate some time to improve the current beta install / future regular install to an acceptable level ? There are some unsolved issues in #4076 and there's more that I just didn't have the time to report / diagnose, but that are very obvious if you try using the new interface.

@dannon

This comment has been minimized.

Copy link
Member

dannon commented Feb 22, 2019

@mvdbeek Totally agree, we need to do that first. I know someone recently said they were going to work on it, but I don't remember who.

@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Feb 22, 2019

Hope that wasn't me 😆

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Feb 22, 2019

I did.

@guerler guerler force-pushed the guerler:activate_toolshed branch from 2157c39 to da8cc8a Feb 26, 2019
@jmchilton jmchilton modified the milestones: 19.05, 19.09 Apr 16, 2019
@guerler guerler added status/review and removed status/WIP labels Apr 20, 2019
@guerler guerler requested a review from mvdbeek Jul 9, 2019
@guerler guerler added status/WIP and removed status/review labels Jul 9, 2019
@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Jul 9, 2019

This looks great to me, but I think something went wrong in merging dev, we now get an additional copy of galaxy.yml.sample when it should be a symlink now.

@guerler

This comment has been minimized.

Copy link
Contributor Author

guerler commented Jul 9, 2019

Ah thanks for catching this.

@guerler guerler force-pushed the guerler:activate_toolshed branch from fbc978e to deaa583 Jul 9, 2019
@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Jul 9, 2019

I don't think we can remove the "Manage Tools" functionality without replacement. There is now no overview of which repos are installed.

@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Jul 9, 2019

Nevermind the last comment -- I just had an empty install database ...

Copy link
Member

mvdbeek left a comment

Awesome, that's a big step forward!

@mvdbeek mvdbeek merged commit bc7b487 into galaxyproject:dev Jul 10, 2019
7 checks passed
7 checks passed
api test Build finished. 496 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 219 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 314 tests run, 22 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@guerler

This comment has been minimized.

Copy link
Contributor Author

guerler commented Jul 10, 2019

@mvdbeek thanks a lot for the help and review on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.