Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] Fix loading workflows with steps without default label #7448

Conversation

Projects
None yet
3 participants
@mvdbeek
Copy link
Member

commented Mar 2, 2019

Broken in #7422.
Prior to #7422
we'd call str(default_label), so if default_label was None
we'd get 'None'. Fixes part of #7447

Fix loading workflows with steps without default label
Prior to #7422
we'd call str(default_label), so if `default_label` was None
we'd get 'None'. Fixes part of #7447

@martenson martenson added this to the 19.05 milestone Mar 3, 2019

@martenson martenson merged commit 996d7c9 into galaxyproject:release_18.09 Mar 3, 2019

6 of 7 checks passed

Build Error Workflow: Build Error
Details
api test Build finished. 432 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 189 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 123 tests run, 10 skipped, 0 failed.
Details
selenium test Build finished. 146 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

thanks for the quick followup @mvdbeek !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.