Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PSA 3.1 and support login with Globus identity #7463

Merged
merged 12 commits into from Mar 11, 2019

Conversation

Projects
None yet
4 participants
@VJalili
Copy link
Member

commented Mar 5, 2019

  • Updates to current latest PSA version (3.1.0);
  • Make some backend configuration generic;
  • Support three new OIDC-based backends: Globus, Elixir, and PixelPin

@galaxybot galaxybot added the triage label Mar 5, 2019

@galaxybot galaxybot added this to the 19.05 milestone Mar 5, 2019

@VJalili

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

@nsoranzo I think sqlalchemy==1.3.0 was the change causing tests failure; maybe some backward incompatible change in newer version of sqlalchemy?! I reverted this change and tests pass locally.

@VJalili VJalili changed the title Update to PSA 3.1 supporting new backends: Globus, Elixir, and PixelPin Update to PSA 3.1 supporting new backends: Globus and PixelPin Mar 11, 2019

@VJalili

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

There are issues with the Elixir backend of PSA as it does not include ID token in its authentication response; hence, it will be supported after that problem is resolved (probably from within PSA).

See: python-social-auth/social-core#327

@VJalili VJalili changed the title Update to PSA 3.1 supporting new backends: Globus and PixelPin Update to PSA 3.1 and support login with Globus identity Mar 11, 2019

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

thanks @VJalili

@martenson martenson merged commit 8ae44cd into galaxyproject:dev Mar 11, 2019

0 of 7 checks passed

Build Error Workflow: Build Error
Details
api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
integration test Test started.
Details
selenium test Test started.
Details
toolshed test Test started.
Details

@VJalili VJalili deleted the VJalili:upgrade_psa_2 branch Mar 11, 2019

@VJalili

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

Thanks for reviewing this @martenson

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@nsoranzo I think sqlalchemy==1.3.0 was the change causing tests failure; maybe some backward incompatible change in newer version of sqlalchemy?! I reverted this change and tests pass locally.

Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.