Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to pass in individual globs to unit test watcher #7477

Merged
merged 2 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@Nerdinacan
Copy link
Contributor

commented Mar 6, 2019

Just a little tiny addition to the client side unit-testing script.

This lets you watch individual tests as you're developing by passing them in a command line arg to the npm test-watch script.

npm run test-watch watch-only="Tags/*.test.js,store/tagStore.test.js"

... will run karma and watch your tests with the following file globs (only).

**/Tags/*.test.js
**/store/tagStore.test.js

@galaxybot galaxybot added the triage label Mar 6, 2019

@galaxybot galaxybot added this to the 19.05 milestone Mar 6, 2019

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

Great idea. Not a major issue, but it seems might be more consistent with the rest of Galaxy's test framework to swap this from using an env var to cli args to specify test globs. What do you think?

@Nerdinacan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

Great idea. Not a major issue, but it seems might be more consistent with the rest of Galaxy's test framework to swap this from using an env var to cli args to specify test globs. What do you think?

Ahh sure I can play with that a bit, I'll see how easy it is to make NPM eat explicit args in its scripts.

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Nice, it's working well for me!

@dannon dannon merged commit 3649c01 into galaxyproject:dev Mar 7, 2019

6 of 7 checks passed

get_code_and_test Workflow: get_code_and_test
Details
api test Build finished. 455 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 210 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 295 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.