Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Okta as OIDC authentication option #7497

Merged
merged 22 commits into from Apr 24, 2020
Merged

Add Okta as OIDC authentication option #7497

merged 22 commits into from Apr 24, 2020

Conversation

selten
Copy link
Contributor

@selten selten commented Mar 9, 2019

Basic idea: add (more/multiple) OIDC IdPs to Galaxy.

@nsoranzo nsoranzo requested a review from VJalili March 9, 2019 17:49
@VJalili
Copy link
Member

VJalili commented Mar 11, 2019

Would you please build this PR based on the latest dev? PSA version is upgraded in #7463 so you may base backend implementation based off that.

VJalili
VJalili suggested changes Mar 25, 2019
View reviewed changes
config/oidc_backends_config.xml.sample Outdated Show resolved Hide resolved
lib/galaxy/authnz/managers.py Show resolved Hide resolved
lib/galaxy/managers/configuration.py Outdated Show resolved Hide resolved
machristie added a commit to machristie/galaxy that referenced this pull request Apr 10, 2019
@machristie
Add OIDC backends to config and display a login button for each
cdd90c1 
This code was taken from the OKTA PR: galaxyproject#7497,
since there is a similar need for the Custos integration to have a login
button.
@machristie machristie mentioned this pull request Apr 10, 2019
Merged
@mvdbeek mvdbeek added area/auth Authentication and authorization kind/enhancement and removed triage labels May 27, 2019
@selten
Merge branch 'dev' of https://github.com/galaxyproject/galaxy into ok…
c01f843 
…ta-oidc-auth

# Conflicts:
#	client/galaxy/scripts/components/login/Login.vue
#	config/oidc_backends_config.xml.sample
#	lib/galaxy/authnz/managers.py
#	lib/galaxy/authnz/psa_authnz.py
#	lib/galaxy/config/__init__.py
#	lib/galaxy/dependencies/__init__.py
@selten
Add Okta to oidc_backends_config.xml.sample
993d899
@selten
Add documentation on how to get the application set up in Okta.
341d555
@selten
Update okta backend name
dbe1fac
@selten
Merge branch 'dev' of https://github.com/galaxyproject/galaxy into ok…
c7d714f 
…ta-oidc-auth
@selten
Merge branch 'dev' of https://github.com/galaxyproject/galaxy into ok…
e612eac 
…ta-oidc-auth
@selten
Update merge
c12a339
@selten
Update social-auth-core to version 3.3.0 and allow no secondary auth …
44ad891 
…to be set if the provider isn't google
@selten selten marked this pull request as ready for review March 18, 2020 22:36
@selten selten changed the title [WIP] Add Okta as OIDC authentication option Add Okta as OIDC authentication option Mar 18, 2020
@selten
Copy link
Contributor Author

selten commented Mar 18, 2020 •
edited

@VJalili could you please review this again? The Okta side was finally implemented on the side of PSA so this PR can finally move from WIP to actual PR.

@VJalili
Copy link
Member

VJalili commented Mar 18, 2020

@selten LGTM, thank you.
Could you please add documentation to the following page? https://github.com/galaxyproject/galaxy-hub/tree/master/src/authnz

Please note that there are use (docs intended for users) and config (docs intended for admins) folders.

@selten
Copy link
Contributor Author

selten commented Mar 18, 2020

I'll write the documentation for this later, thanks for pointing it out to me

@dannon dannon removed the status/WIP label Mar 19, 2020
@galaxybot galaxybot added this to the 20.05 milestone Mar 19, 2020
@selten selten mentioned this pull request Mar 19, 2020
Closed
@selten selten mentioned this pull request Mar 27, 2020
Merged
@mvdbeek
Copy link
Member

mvdbeek commented Apr 20, 2020

@selten can you rebase this ?

@mvdbeek mvdbeek self-assigned this Apr 20, 2020
@selten
Copy link
Contributor Author

selten commented Apr 20, 2020

@mvdbeek i merged the changes from dev into this branch, is that also fine?

@mvdbeek
Copy link
Member

mvdbeek commented Apr 21, 2020

That's fine, but there are style issues in Login.vue, can you resolve those?

@selten
Copy link
Contributor Author

selten commented Apr 21, 2020

@mvdbeek should be fixed now.

@mvdbeek mvdbeek merged commit 21d1507 into galaxyproject:dev Apr 24, 2020
@mvdbeek
Copy link
Member

mvdbeek commented Apr 24, 2020

Thank you @selten !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VJalili VJalili VJalili approved these changes

Assignees

@mvdbeek mvdbeek

Labels
area/auth Authentication and authorization kind/enhancement
Projects
None yet
Milestone
20.05
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@selten @VJalili @mvdbeek @dannon @galaxybot