Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.01] User facing release notes #7527

Merged
merged 5 commits into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@erasche
Copy link
Member

commented Mar 14, 2019

Fixes #7425 :)

I've made an attempt at updating bootstrap_history.py but I am ... quite unconfident in my changes. :(

I have not linked to the user announcements from anywhere, not sure where that would happen. I volunteer to write these for the foreseeable future.

@erasche erasche referenced this pull request Mar 14, 2019

Closed

19.01 update news item #205

0 of 1 task complete
@dannon

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

I definitely like the presentation here, seems more useful for the majority of readers than the other format.

I initially thought we might want to come up with some other approach for images, but I don't know that it's (~200k a few times per year) worth worrying about to try to do anything other than include them in the repo as you've done here.

@erasche

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

yeah, just a different (and maybe larger) target audience, I still find utility in the full release notes, I skim them every time for interesting things that have been included. Hopefully something easily consumable/redistributable by admins and community managers.

I ran optipng on all of these, given the width of the documentation could potentially shave a few more bytes off but yeah maybe not worth it to either do that or to explore s3 type options.

@erasche

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

@dannon any more comments or are you OK with this? :)

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

@erasche Oh, yeah, sorry that wasn't clear -- I like them. I have not tried to run your changes to the bootstrapper, but I can check that out later if you'd like.

@erasche

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

Sure, if you have time, that'd be great. If not, I can drop my changes to the bootstrap script? I'd like to be able to link people to the notes when we do manage to upgrade at least.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

These are no doubt nice and I understand the appeal of targeting a different audience. Selfishly, I just don't love creating more work indefinitely. Is Freiburg willing to commit to writing these going forward or does this fall on the release manager? If this is merged, we can automate picking out the datatype changes and tool changes using tags and pre-populate some of that stuff.

@erasche

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

Is Freiburg willing to commit to writing these going forward or does this fall on the release manager?

I am willing to commit to writing the highlights, if we can automate the rest that would be brilliant. Even for the this PR, it was nice to have a reason to explore the WF parameters, I might not have for another few months otherwise.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

If you do that write up, I'll do the rest and automate what I can for 19.05. You can have my +1 I suppose, thanks!

dannon added some commits Mar 19, 2019

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@erasche Pushed one bug fix and one bit of cleanup, looks like it'll work now to me. (But I guess @jmchilton will take care of it when 19.05 rolls around if not ;))

@erasche

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

Thanks for the fixes @dannon!

@dannon dannon merged commit 779e775 into galaxyproject:release_19.01 Mar 19, 2019

6 of 7 checks passed

Build Error Workflow: Build Error
Details
api test Build finished. 455 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 197 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 287 tests run, 12 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 4 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

How is this going to be presented? A link from the general release notes?

@erasche

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

@martenson per comments in OP, no idea. We could link from general, I thought about something like "Release notes to send to your users" but didn't have a good place to put that that wouldn't either be completely skipped over, or way too prominent.

@erasche erasche deleted the erasche:user-release-notes branch Mar 19, 2019

@erasche

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

Maybe we leave it alone this release, and next release if I write some nice notes we can add it as a 4th highlighted feature? And then in future just a small link somewhere of "user facing release notes"

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

I wouldn't be afraid of giving it prominent spot - as a highlight or link above the highlights.

@erasche erasche modified the milestones: 19.01, 19.05 Mar 19, 2019

@galaxyproject galaxyproject deleted a comment from galaxybot Mar 19, 2019

jmchilton added a commit to jmchilton/galaxy that referenced this pull request May 24, 2019

Fixes and enhancements for release note generation.
- Auto-bootstrap user announcements for datatypes, tools, and viz. (follow up on galaxyproject#7527)
- Many fixes for things broken in galaxyproject#7527
- Treat procedures as an enhancment for categorizing things.
- Speed up release note generation a bit by not considering really, really old PRs.

jmchilton added a commit to jmchilton/galaxy that referenced this pull request May 24, 2019

Fixes and enhancements for release note generation.
- Auto-bootstrap user announcements for datatypes, tools, and viz. (follow up on galaxyproject#7527)
- Many fixes for things broken in galaxyproject#7527
- Treat procedures as an enhancment for categorizing things.
- Speed up release note generation a bit by not considering really, really old PRs.

jmchilton added a commit to jmchilton/galaxy that referenced this pull request May 24, 2019

Fixes and enhancements for release note generation.
- Auto-bootstrap user announcements for datatypes, tools, and viz. (follow up on galaxyproject#7527)
- Many fixes for things broken in galaxyproject#7527
- Treat procedures as an enhancment for categorizing things.
- Speed up release note generation a bit by not considering really, really old PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.