Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run circleCI on merge rather than head of PR's fork #7539

Merged
merged 2 commits into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@martenson
Copy link
Member

commented Mar 15, 2019

this is taking advantage of github providing refs to preliminary merges of PRs

this is a missing feature in circleci: https://circleci.com/ideas/?idea=CCI-I-431

@martenson

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

well circleCI won't build it since it already built the hash for my fork when I was testing this (but it does not display results here)

@jmchilton jmchilton merged commit 5cdbf88 into galaxyproject:dev Mar 18, 2019

7 checks passed

api test Build finished. 465 tests run, 2 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 297 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the martenson:circlePR branch Mar 21, 2019

nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.