Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styleguide #7602

Merged
merged 5 commits into from Mar 26, 2019

Conversation

Projects
None yet
2 participants
@dannon
Copy link
Member

commented Mar 26, 2019

Didn't track down when this broke, but it has been a while. To test this, you can run yarn run styleguide and then look at the local webserver.

We should be making better use of the styleguide and using it in development. I'm hoping to include vue components (like the recent badges/tags, etc) as well in the near future.

@dannon dannon force-pushed the dannon:fix-styleguide branch from ce725d8 to 6826747 Mar 26, 2019

@dannon dannon marked this pull request as ready for review Mar 26, 2019

@dannon dannon added this to the 19.05 milestone Mar 26, 2019

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

damn, 2.5k lines yarn.lock change for a styleguideist update

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

Yep. It has lots of dependencies, and this was two major version bumps.

The good news is that it works again, pretty nicely. I've started experimenting adding Vue components to it and it's going to be very helpful moving forward.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

Looks like TravisCI completed, it's just not updating here? This is good to go.

@martenson martenson merged commit 01c7200 into galaxyproject:dev Mar 26, 2019

6 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
api test Build finished. 478 tests run, 1 skipped, 0 failed.
Details
framework test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 298 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

@martenson Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.