Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When submitting tool error reports, include 'old' tool id as part of subject line. #761

Merged
merged 1 commit into from Sep 21, 2015

Conversation

Projects
None yet
3 participants
@blankenberg
Copy link
Member

commented Sep 21, 2015

Makes sifting through bug report emails easier, old id is used for brevity, but full guid is still included in text of report.

When submitting tool error reports, include 'old' tool id as part of …
…subject line. Makes sifting through bug report emails easier, old id is used for brevity, but full guid is still included in text of report.

martenson added a commit that referenced this pull request Sep 21, 2015

Merge pull request #761 from blankenberg/error-tool-id
When submitting tool error reports, include 'old' tool id as part of subject line.

@martenson martenson merged commit c7394bd into galaxyproject:dev Sep 21, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@@ -133,5 +133,9 @@ def _send_report( self, user, email=None, message=None, **kwd ):
else:
to = to_address
subject = "Galaxy tool error report from %s" % email
try:
subject = "%s (%s)" % ( subject, self.app.toolbox.get_tool( self.job.tool_id, self.job.tool_version ).old_id )
except:

This comment has been minimized.

Copy link
@jmchilton

jmchilton Sep 21, 2015

Member

Can you make this at very least a except Exception: or even more preferably whatever specific exception results when an unknown tool id and version are found.

Bare excepts are an anti-pattern - https://docs.python.org/2/howto/doanddont.html#except - and we should eliminate them from Galaxy.

@blankenberg blankenberg deleted the blankenberg:error-tool-id branch Sep 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.