Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history options menu href navigation #7612

Merged
merged 2 commits into from Apr 6, 2019

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Mar 27, 2019

Leaving this wip for a sec while I try to understand what exactly changed here, why 'galay_main' is ending up as a string hanging off the parent object instead of being the frame target, but this simplifies the logic a little (and works, for me).

I still don't quite get what happened here, but this works well in my testing, so I'm moving on.

fixes #7608

dannon added some commits Mar 27, 2019

Leave window.parent jump-out-of-frame guard in place here even though…
… I hope we're not still using this from within frames?

@dannon dannon marked this pull request as ready for review Mar 27, 2019

@galaxybot galaxybot added the triage label Mar 27, 2019

@galaxybot galaxybot added this to the 19.05 milestone Mar 27, 2019

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Thanks dannon, works well for me too.

@mvdbeek mvdbeek merged commit 22f88fc into galaxyproject:dev Apr 6, 2019

7 checks passed

api test Build finished. 478 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 300 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

thanks @dannon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.