Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete cloudauthz record from database instead of marking it as deleted #7639

Merged
merged 3 commits into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@VJalili
Copy link
Member

commented Apr 1, 2019

@martenson can we modify this migration script? I guess no newer script exists, and previous script was not included in 19.01 release.

@martenson

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

@VJalili there is no migration-consistency check, so instances running dev will not re-run the migration and will be stuck with the column. Which is probably fine.

@VJalili

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

Agree.

@martenson martenson added this to the 19.05 milestone Apr 1, 2019

@jmchilton jmchilton merged commit ed2008f into galaxyproject:dev Apr 2, 2019

7 checks passed

api test Build finished. 480 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 300 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Agree also, merging fast to minimize the damage though. Thanks!

@VJalili

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

Thanks @jmchilton

@VJalili VJalili deleted the VJalili:remove_cloudauthz branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.