Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue gracefully in set_meta if unable to count number of dataset lines. #7641

Merged
merged 2 commits into from Apr 3, 2019

Conversation

Projects
None yet
4 participants
@blankenberg
Copy link
Member

commented Apr 1, 2019

Possibly caused by datatype inconsistency (e.g. binary set as text), which is corrected elsewhere, but would cause otherwise unnecessary job failure here.

@galaxybot galaxybot added the triage label Apr 1, 2019

@galaxybot galaxybot added this to the 19.05 milestone Apr 1, 2019

@martenson

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

lgtm. Should we even have upper bound of how many lines we care about?

@mvdbeek

mvdbeek approved these changes Apr 3, 2019

@martenson martenson merged commit 8aeb1c0 into galaxyproject:dev Apr 3, 2019

7 checks passed

api test Build finished. 481 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 300 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 4 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.