Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import of format2 workflows by default for 19.05. #7659

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
5 participants
@jmchilton
Copy link
Member

commented Apr 4, 2019

Setup forcing export of format2 workflows by default in next release. There should be a least one release between enabling them to be imported by default and exporting them by default anyway I think - so 19.09 workflows can still be used on slightly older Galaxy instances.

Allow import format2 workflows by default.
Setup forcing export of format2 workflows by default in next release. There should be a least one release between enabling them to be imported by default and exporting them by default anyway I think - so 19.09 workflows can still be used on slightly older Galaxy instances.
@nsoranzo

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Can we allow the user to choose the format? Then we can just change the default to format2 directly, and have the format1 is still available as an option in the UI.

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

It is certainly an option, and if you insist I can try to work on that but I'd prefer not to I think. I think those are details we don't want users to care about? Also I'm not sure I'm ready for export by default yet. So I prefer this two-stage rollout.

@jmchilton jmchilton changed the title Allow import format2 workflows by default for 19.05. Allow import of format2 workflows by default for 19.05. Apr 4, 2019

@galaxybot galaxybot added this to the 19.05 milestone Apr 4, 2019

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

I think those are details we don't want users to care about?

Since the main reason for an export is allowing the import of the workflow on another Galaxy instance, we cannot ignore that there are loads of instances around that are stuck on very old releases.
Also, in the future we will hopefully have the option of exporting in CWL format, so we are going to need this user-visible option any way.
This is not needed for this PR to be merged, though, only when we switch the default, I think.

Also I'm not sure I'm ready for export by default yet. So I prefer this two-stage rollout.

That's surely fine.

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

This is not needed for this PR to be merged, though, only when we switch the default, I think.

Let's table this then and pick that conversation back up in 19.09. I'm not totally sold and I'm tempted to remove the parts of this that promise the default will switch in 19.09 but perhaps it is too small a point to get so hung up on.

Thanks for the input @nsoranzo, it was well articulated and much appreciated.

@mvdbeek

mvdbeek approved these changes Apr 8, 2019

Copy link
Member

left a comment

I think allowing the import should be fine, whether or not we do the default switch I think we can discuss later ? In any case format2 exports are still a little fragile (completely unrelated to the PR).

@martenson martenson merged commit 1075a0e into galaxyproject:dev Apr 9, 2019

7 checks passed

api test Build finished. 481 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 300 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details

@martenson martenson deleted the jmchilton:format2_import_default branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.