Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix genomespace exporter tool #7697

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Apr 9, 2019

Specify profile and look for exit codes for genomespace tool -- warnings cause failures otherwise.

Someone more familiar with the tool -- is this going to work like I expect, or is it going to potentially fail without returning a nonzero exit code?

And, we may need to apply this to the other genomespace tools using cloudbridge as well.

xref #7647 (comment)

@dannon dannon changed the title Specify profile and look for exit codes for genomespace tool Fix genomespace exporter tool Apr 9, 2019

@mvdbeek

mvdbeek approved these changes Apr 9, 2019

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Yes, that should fix it, it looks like GenomeSpaceClient just raises the proper exceptions, so the python interpreter will quit with a non-zero exit code.

@mvdbeek

mvdbeek approved these changes Apr 9, 2019

@galaxybot galaxybot added the triage label Apr 9, 2019

@galaxybot galaxybot added this to the 19.05 milestone Apr 9, 2019

@blankenberg blankenberg merged commit ff1313f into galaxyproject:dev Apr 9, 2019

7 checks passed

api test Build finished. 484 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 215 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 300 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@blankenberg

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Any volunteers to target this to 19.01 as well? (updated usegalaxy.org has this issue currently)

@dannon

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

@blankenberg Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.