Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the 1st line sniffing for mtx (not only real coordinate) #7702

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@bebatut
Copy link
Member

commented Apr 9, 2019

Hi,

The sniffing of the 1st line of mtx file is currently too strict.
This PR should fix that

Bérénice

@galaxybot galaxybot added the triage label Apr 9, 2019

@galaxybot galaxybot added this to the 19.05 milestone Apr 9, 2019

@erasche

erasche approved these changes Apr 9, 2019

@erasche erasche added area/datatypes kind/bug and removed triage labels Apr 9, 2019

@jmchilton jmchilton merged commit ee770ca into galaxyproject:dev Apr 9, 2019

7 checks passed

api test Build finished. 484 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 215 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 303 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Thanks, looks good to me!

@bebatut bebatut deleted the bebatut:fix_mtx_sniff branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.