Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many more migration fixes #7737

Merged
merged 6 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

commented Apr 13, 2019

See individual commits for details.

nsoranzo added some commits Apr 12, 2019

Fix downgrade in migration 57 for non-SQLite databases
`notify` column need to be re-added.
Fix foreign keys in migration 68 for SQLite
SQLite does not always update foreign key constraints when the target
table is renamed, so we start with the table rename in both `upgrade()`
and `downgrade()`.

xref. https://www.sqlite.org/lang_altertable.html
Uniform handling of SQLAlchemy Migrate bug
when adding a column with both a ForeignKey and a index in SQLite.

Also add proper downgrade to migration 37.

@nsoranzo nsoranzo added this to the 19.05 milestone Apr 13, 2019

@jmchilton jmchilton merged commit 2d2c7ab into galaxyproject:dev Apr 15, 2019

7 checks passed

api test Build finished. 485 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 217 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 305 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:more_migration_fixes branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.