Add option to wait for db to become available #7827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configurable option to wait for the database to become available instead of failing immediately. _configure_models() seems to be the earliest/reasonable place for it.
This test file contained 2 basic unit tests that tested the proposed new config values. Instantiating a Configuration object without passing the required arguments seems to have caused other tests to fail. Trying same PR without additional unit tests.
Fixing lint error
nsoranzo
reviewed
Apr 26, 2019
|
|
nsoranzo
reviewed
Apr 26, 2019
Co-Authored-By: ic4f <sgolitsynskiy@gmail.com>
time module already imported.
nsoranzo
added
area/database
jdavcs
changed the title
jdavcs
changed the title
nsoranzo
approved these changes
Apr 28, 2019
|
@ic4f Still WIP? |
nuwang
reviewed
Apr 28, 2019
Break out of loop upon successfully connecting to db.
nsoranzo
approved these changes
Apr 29, 2019
|
Selenium error is unrelated. Thanks @ic4f! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurable option to wait for the database to become available instead
of failing immediately.
_configure_models() seems to be the earliest/reasonable place for it.