Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.05] improve upload ux #7848

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@martenson
Copy link
Member

commented Apr 29, 2019

As discussed here: https://help.galaxyproject.org/t/editing-workflow-with-screen-reader/892/10 the usability of upload with screen reader is problematic. This PR does two things:

  • everything using mvc/ui/ui-tabs.js will have focusable tabs, which should ease the non-visual navigation
  • after opening every modal based on mvc/ui/ui-modal.js the focus will be set to its title which will prevent user to be 'lost' in the background of the modal

martenson added some commits Apr 29, 2019

@martenson martenson added this to the 19.05 milestone Apr 29, 2019

@martenson martenson changed the title [19.05] Fix upload ux [19.05] improve upload ux Apr 29, 2019

@dannon dannon merged commit 6e47957 into galaxyproject:release_19.05 Apr 30, 2019

7 checks passed

api test Build finished. 491 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 217 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 306 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details

@martenson martenson deleted the martenson:upload-ux branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.