Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.05] Interactive Environment Fixes #7917

Merged
merged 19 commits into from May 10, 2019

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented May 8, 2019

With the removal of the (long deprecated) static libs (in this case, specifically requirejs, toastr, and jquery) staged for external consumption during this past cycle IE setup was broken.

This PR adjusts all IES to use bundled libraries via the generic Galaxy entrypoint we provide, be requirejs-free, and along the way takes several refactoring steps towards providing a single pluggable interface that hopefully (will target dev, not a release branch with this) will eventually allow creation of new IES without writing custom javascript (and hopefully mako, eventually) at all.

WIP for a few while I follow up on Toastr, but this is enough to get IEs functional as-is.

@dannon dannon added status/review and removed status/WIP labels May 8, 2019

dannon and others added some commits May 8, 2019

Merge pull request #43 from mvdbeek/dannon-release_static_fixes
Fix byte-unicode issue when using Popen
@mvdbeek

mvdbeek approved these changes May 9, 2019

Copy link
Member

left a comment

Great, works for me! The rstudio issue should be resolved with erasche/docker-rstudio-notebook#23

@erasche

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Merged and rebuilt, @mvdbeek look ok now?

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

@erasche Thanks, I'll re-fetch and test it now. Going to push one more minor tweak in a sec to the docs here to mention host.docker.internal magic alias as the galaxy_infra_url.

(It worked great)

Document the modern docker networking special DNS 'host.docker.intern…
…al' for use with GIES. Fix another typo I saw.
Show resolved Hide resolved config/galaxy.yml.sample Outdated

@mvdbeek mvdbeek merged commit 99a86ea into galaxyproject:release_19.05 May 10, 2019

6 of 7 checks passed

framework test Build finished. 218 tests run, 0 skipped, 0 failed.
Details
api test Build finished. 491 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 306 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@mvdbeek

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Thanks @dannon, looks very good. Test failure was unrelated, we may just need to give Jenkins a little more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.