Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.05] Update tool output datatype in workflow editor if datatype changes #7989

Merged

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented May 16, 2019

This adds the force_dataype key value pair into the step dict on the backend, which means that subworkflows outputs and tools that have a change datatype PJA will display the correct output datatype.
The client now also sets force_datatype when changing the PJA and updates the node's output label to indicate the new output datatype.

fixes #7965 and #4813

Reflect changed datatype in workflow editor
This has some caveats here: We don't store the original
datatype, so if we want to switch back to whatever the
tool produces you have to know the datatype.
Probably need an additional attribute on the output
terminal that si the actual tool extension.

mvdbeek added some commits May 16, 2019

Distinguish tool datatype and PJA (=forced_dataype)
This makes it easier switching back to the default datatype
and unifies front- and backend changes.
This fixes #7965
and #4813
Fix/remove karma tests
Removed the karma test that checks whether a PJA to an unrelated
output doesn't affect the current output.
This is now determined on the backend (allows PJAs to have an effect
in the workflow editor), so I removed this test.

@mvdbeek mvdbeek force-pushed the mvdbeek:fix_force_datatype_changes branch from 176125d to 459f283 May 16, 2019

@jmchilton

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Well this is pretty exciting, thanks a bunch @mvdbeek !

@mvdbeek mvdbeek added this to the 19.05 milestone May 16, 2019

@jmchilton jmchilton merged commit 47b27be into galaxyproject:release_19.05 May 20, 2019

7 checks passed

api test Build finished. 492 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 218 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 307 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details

mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request May 27, 2019

Update node.post_job_actions when changing post job actions
I broke persisting pot job actions in
galaxyproject#7989.
The onchange function prevented updating the post job action.

mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request May 27, 2019

Update node.post_job_actions when changing post job actions
I broke persisting pot job actions in
galaxyproject#7989.
The onchange function prevented updating the post job action.

mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request May 28, 2019

Update node.post_job_actions when changing post job actions
I broke persisting pot job actions in
galaxyproject#7989.
The onchange function prevented updating the post job action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.