Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes / CLI runner integration test fixes #8154

Merged
merged 2 commits into from Jun 16, 2019

Conversation

@mvdbeek
Copy link
Member

mvdbeek commented Jun 16, 2019

These are required to run the kubernetes tests. The job config files now have to contain .xml (#7854). stream_to_file may receive StringIO objects, so chunk may be unicode. In that case we need to call encode.

@galaxybot galaxybot added this to the 19.09 milestone Jun 16, 2019
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Jun 16, 2019

Sorry about breaking that :(

@mvdbeek

This comment has been minimized.

Copy link
Member Author

mvdbeek commented Jun 16, 2019

No worries, was easy enough to figure out. Also I reviewed the PR, so could have thought about that myself. On top of that I should have added a suffix in the first place. And then I should probably move this to yml, since it'll be easier to adjust dynamically ... :). And #8050 broke some part of the upload by url functionality ...

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Jun 16, 2019

I think the "job config file name should contain .xml if it's in XML format" has been introduced in #7854 , not #8118 , or am I missing something?

@mvdbeek

This comment has been minimized.

Copy link
Member Author

mvdbeek commented Jun 16, 2019

Yes, you're right of course!

@nsoranzo nsoranzo merged commit bf95a46 into galaxyproject:dev Jun 16, 2019
7 checks passed
7 checks passed
api test Build finished. 495 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 218 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 309 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@nsoranzo nsoranzo deleted the mvdbeek:kubernetes_test_fixes branch Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.