Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to fail job when tool is unavailable #8181

Merged
merged 2 commits into from Jun 18, 2019

Conversation

@mvdbeek
Copy link
Member

mvdbeek commented Jun 18, 2019

That fixes #8141 (mostly)

@mvdbeek mvdbeek requested a review from natefoo Jun 18, 2019
That fixes the underlying problem in
#8141
but doesn't implement the outer try/except suggested
by @natefoo.
@mvdbeek mvdbeek force-pushed the mvdbeek:fix_job_fail_fail_invalid_tool branch from 91ade8d to 4c83abc Jun 18, 2019
@galaxybot galaxybot added the triage label Jun 18, 2019
@galaxybot galaxybot added this to the 19.09 milestone Jun 18, 2019
@jmchilton jmchilton merged commit a7e394a into galaxyproject:dev Jun 18, 2019
7 checks passed
7 checks passed
api test Build finished. 495 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 219 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 310 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment was marked as resolved.

Copy link

galaxybot commented Jun 18, 2019

This PR was merged without a 'kind/' tag, please correct.

@martenson martenson added kind/bug area/jobs and removed triage labels Jun 18, 2019
@nsoranzo nsoranzo deleted the mvdbeek:fix_job_fail_fail_invalid_tool branch Jun 19, 2019
@nsoranzo nsoranzo mentioned this pull request Sep 10, 2019
mvdbeek added a commit that referenced this pull request Sep 10, 2019
[19.05] Backport #8181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.