Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make styleguide work for vue components. #8291

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@jxtx
Copy link
Contributor

jxtx commented Jul 7, 2019

All components are now loaded in the styleguide, however to document
them jsdoc comments need to be added and .md files for examples. The
Alert component is now documented as an example.

Unfortunately many of our components use axios to access the API
immediately on creation. I'm not sure how to document these. It seems
like a bad thing that they do this...

styleguide

All components are now loaded in the styleguide, however to document
them jsdoc comments need to be added and `.md` files for examples. The
Alert component is now documented as an example.

Unfortunately many of our components use axios to access the API
immediately on creation. I'm not sure how to document these. It seems
like a bad thing that they do this...
@jxtx jxtx requested a review from dannon Jul 7, 2019
@galaxybot galaxybot added the triage label Jul 7, 2019
@galaxybot galaxybot added this to the 19.09 milestone Jul 7, 2019
@jmchilton jmchilton merged commit 79c129f into galaxyproject:dev Aug 22, 2019
7 checks passed
7 checks passed
api test Build finished. 496 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 219 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 314 tests run, 22 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.