Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] Specify a default tool error reports plugin config rather than reading it from the sample #8702

Merged

Conversation

@natefoo
Copy link
Member

natefoo commented Sep 24, 2019

No description provided.

@natefoo natefoo added this to the 19.09 milestone Sep 24, 2019
@@ -8,6 +9,9 @@
from galaxy.util.submodules import import_submodules


PluginConfigSource = collections.namedtuple('PluginConfigSource', ['type', 'source'])

This comment has been minimized.

Copy link
@jmchilton

This comment has been minimized.

Copy link
@natefoo

natefoo Sep 24, 2019

Author Member

I strongly dislike accessing non-local tuples by index.

This comment has been minimized.

Copy link
@jmchilton

jmchilton Sep 24, 2019

Member

It was a good tophat 🤣

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Sep 24, 2019

Member

Shouldn't also load_plugins() been modified at line 40 to use the keys?

This comment has been minimized.

Copy link
@natefoo

natefoo Sep 25, 2019

Author Member

@nsoranzo There are other callers still passing a tuple apparently.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Sep 25, 2019

Member

Are there? I couldn't find any in lib/galaxy/job_metrics/__init__.py , lib/galaxy/tool_util/deps/__init__.py , lib/galaxy/tool_util/deps/containers.py or lib/galaxy/tools/error_reports/__init__.py .

This comment has been minimized.

Copy link
@natefoo

This comment has been minimized.

Copy link
@jmchilton

jmchilton Sep 25, 2019

Member

This is going to conflict https://github.com/galaxyproject/galaxy/pull/8616/files isn't it, I shouldn't have taken so long to respond to the review of it.

This comment has been minimized.

Copy link
@jmchilton
@natefoo natefoo force-pushed the natefoo:error-reports-config-fix branch from ab17135 to eabaa74 Sep 25, 2019
@jmchilton jmchilton merged commit 72b35dc into galaxyproject:release_19.09 Sep 25, 2019
10 checks passed
10 checks passed
api test Build finished. 510 tests run, 1 skipped, 0 failed.
Details
api test python 3 Build finished. 510 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
doc building test Build finished. No test results found.
Details
framework test python 3 Build finished. 220 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 323 tests run, 27 skipped, 0 failed.
Details
integration test python 3 Build finished. 323 tests run, 27 skipped, 0 failed.
Details
selenium test python 3 Build finished. 152 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.