Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] Fix DetachedInstanceError when tool shed packages are in play #8933

Merged

Conversation

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Nov 5, 2019

The fix is to eagerload the child tool_dependency to tool shed repository relation as well.

@martenson
Copy link
Member

@martenson martenson commented Nov 5, 2019

Should this target 19.09?

Loading

@mvdbeek mvdbeek force-pushed the one_more_detached_instance branch from 71ea1f6 to 29091a0 Nov 5, 2019
@mvdbeek mvdbeek changed the base branch from dev to release_19.09 Nov 5, 2019
@mvdbeek mvdbeek changed the title Fix DetachedInstanceError when tool shed packages are in play [19.09] Fix DetachedInstanceError when tool shed packages are in play Nov 5, 2019
@mvdbeek mvdbeek force-pushed the one_more_detached_instance branch from 29091a0 to 22b1a3c Nov 5, 2019
@jmchilton jmchilton merged commit 9aec180 into galaxyproject:release_19.09 Nov 7, 2019
10 checks passed
Loading
@nsoranzo nsoranzo deleted the one_more_detached_instance branch Nov 7, 2019
@nsoranzo nsoranzo added this to the 19.09 milestone Nov 7, 2019
@galaxyproject galaxyproject deleted a comment from galaxybot Nov 7, 2019
@nagoue
Copy link
Contributor

@nagoue nagoue commented Nov 18, 2020

Hi, I got the same error message ( Parent instance <ToolShedRepository at 0x7f339f9b9a10> is not bound to a Session; deferred load operation of attribute 'metadata' cannot proceed ), but I am still in Galaxy 19.09. May you help on this ?

Loading

@ic4f
Copy link
Member

@ic4f ic4f commented Mar 30, 2021

@nagoue This issue has been fixed and backported to 19.09 in #9354. If you still get this kind of error, please open a new issue. Sorry for the late reply: I saw your comment by accident. If you have any questions/issues/etc. on Galaxy, please contact us on Gitter https://gitter.im/galaxyproject/dev , or, again, feel free to open an issue.

Loading

@nagoue
Copy link
Contributor

@nagoue nagoue commented Mar 30, 2021

@ic4f, never too late ! Thanks for your reply. Cheers

Loading

ic4f added a commit to ic4f/galaxy that referenced this issue Apr 4, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
ic4f added a commit to ic4f/galaxy that referenced this issue Apr 4, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
ic4f added a commit to ic4f/galaxy that referenced this issue Apr 6, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
ic4f added a commit to ic4f/galaxy that referenced this issue Apr 7, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
ic4f added a commit to ic4f/galaxy that referenced this issue Apr 9, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
ic4f added a commit to ic4f/galaxy that referenced this issue Apr 9, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
ic4f added a commit to ic4f/galaxy that referenced this issue Apr 30, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
ic4f added a commit to ic4f/galaxy that referenced this issue May 5, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
ic4f added a commit to ic4f/galaxy that referenced this issue May 13, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
ic4f added a commit to ic4f/galaxy that referenced this issue May 18, 2021
This appears to be creating a redundant join.
The tool dependency is already eagerly loaded and the subqueryload joins
the same tool_shed_repository that is already in the query.

This causes a bug under SQLAlchemy 1.4: the deferred option is not
applied to repository.metadata.

(This reverts galaxyproject#8933)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants