Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder workflow inputs to top #912

Merged
merged 1 commit into from Oct 15, 2015

Conversation

@scholtalbers
Copy link
Contributor

scholtalbers commented Oct 14, 2015

This renders the workflow inputs at the top of the tool list. This feels more natural to me as a user.
However, the workflow modules sections are now in a dictionary and explicit ordering might be needed if more are actually added.

http://pasteboard.co/1mLyQ4sT.png

@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Oct 14, 2015

Good idea, this increases usability!

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Oct 14, 2015

This kind of jumps through some hoops in the code to make sure extra workflow modules (beta ones) are still at the bottom. I feel like it would simplify things to make that modules_section back into a list and just put all the workflow specific modules right at the top - no reason tools need to come first and in fact they probably shouldn't give the list is rather unbounded in size potentially and very familiar to user, they will never expect anything to be below it. I'm 👍 either way, this is a clear improvement to usability but I would much prefer to just throw all those modules at top and re-simplify things.

@hexylena

This comment has been minimized.

Copy link
Member

hexylena commented Oct 14, 2015

👍 I've been asking for this forever.

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Oct 14, 2015

@galaxybot test this

@scholtalbers

This comment has been minimized.

Copy link
Contributor Author

scholtalbers commented Oct 15, 2015

@jmchilton I intentionally did not put all modules at the top because it might already confuse users now that these modules are not filtered when searching. Having inputs fixed at the top seems ok, but actions I would expect to be filtered if seen at the top. To simplify or ensure ordering modules could be put back in a list and assume inputs is the first in the list.

@dannon

This comment has been minimized.

Copy link
Member

dannon commented Oct 15, 2015

+1, looks good!

dannon added a commit that referenced this pull request Oct 15, 2015
Reorder workflow inputs to top
@dannon dannon merged commit 296dab0 into galaxyproject:dev Oct 15, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 87 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.