[19.09] Always add shed_tool_config file to tool_configs #9364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
fix_tools_disappearing_after_restart
branch
from
ecf138f
to
3a994cb
This should fix galaxyproject#9356 The bug itself was due to not calling toolbox._load_tool_panel() after injecting the default shed_tool_config_file into the toolbox, but implentation-wise it seems better to have this logic inside the toolbox.
mvdbeek
force-pushed
the
fix_tools_disappearing_after_restart
branch
from
3a994cb
to
0421553
nsoranzo
approved these changes
Feb 12, 2020
nsoranzo
merged commit 1930a0f
into
galaxyproject:release_19.09
8 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This should fix #9356
The bug itself was due to not calling
toolbox._load_tool_panel()(introduced in #8999) after injecting the default shed_tool_config_file into the toolbox, but implementation-wise it seems better to have this logic inside the toolbox.The text was updated successfully, but these errors were encountered: