New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable workflow parameter switch for data inputs, augment form handling #9551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Mar 22, 2020
guerler
force-pushed
the
workflow_fixes
branch
2 times, most recently
from
March 23, 2020 14:46
25393e3
to
d2c5e4b
Compare
dannon
reviewed
Mar 29, 2020
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the workflow parameter double-arrow switch for data inputs, since those are already attached to the workflow nodes. Additionally it fixes switching between workflow tool forms and the reports help in the editor panel. The customization flow for workflow tool forms has been revised such that it does not require additional callbacks. The PR also removes
jquery
from theworkflow-forms
class.