New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Planemo Bus Factor #329

Open
jmchilton opened this Issue Oct 15, 2015 · 16 comments

Comments

Projects
None yet
4 participants
@jmchilton
Copy link
Member

jmchilton commented Oct 15, 2015

Have someone besides @jmchilton do a release of planemo.

Update - current plan is

  • Implement release testing #184.
  • Modify make release to test release instead of reviewing testpypi.
  • Modify make release to infer default versions automatically.
  • Update galaxyproject's jenkins to be able to publish to PyPI.
  • Add a jenkins job to release Planemo.
  • Have @davebx put together release notes and do a release.
@erasche

This comment has been minimized.

Copy link
Member

erasche commented Oct 15, 2015

Oooh fun. I vote for jenkins 😉

Continuous Delivery ftw.

@davebx davebx self-assigned this Oct 15, 2015

@davebx

This comment has been minimized.

Copy link
Contributor

davebx commented Oct 15, 2015

A wild volunteer appeared! That said, it would probably be even most ideal if several people had the ability.

@erasche

This comment has been minimized.

Copy link
Member

erasche commented Oct 15, 2015

@davebx ooh yay a volunteer! See if you can't checklist-ify and automate https://github.com/galaxyproject/planemo/blob/master/docs/developing.rst :)

@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented Oct 15, 2015

@davebx - How about you push the button but we configure jenkins with the keys.

We should I guess fully automate:

make clean && make lint && make test
make release VERSION=<old_version> NEW_VERSION=<new_version>
make push-release

There is a review step in there, it pauses and opens a web browser to Test PyPI but maybe that is not needed. Maybe the right thing is to just do an install and run some simple tests.

@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented Oct 15, 2015

xref #184

If that worked we could do a release to test PyPI and not need an explicit review I think.

@erasche

This comment has been minimized.

Copy link
Member

erasche commented Oct 15, 2015

💯

@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented Oct 15, 2015

P.S. I'm not planning on quiting or getting hit by a bus, but I realized I totally merged #327 when other people when doing just fine working on the issue - it would be better for me to step back and let the project evolve from under my heavy boot 😄.

@davebx

This comment has been minimized.

Copy link
Contributor

davebx commented Oct 15, 2015

@jmchilton Yes, too long has planemo languished in the iron fist of its tyrant lord. Or something.

@erasche

This comment has been minimized.

Copy link
Member

erasche commented Oct 15, 2015

(P.S. I was actually hoping you'd sign off/sanity check that one since you wrote the vast majority of the code surrounding it/affected by it.)

@jmchilton jmchilton removed the help wanted label Oct 19, 2015

@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented Oct 19, 2015

Updated this issue with a checklist based on these conversations - feel free to tweak.

#184 seemed like a cool but non-essential idea at one point but now seems more and more important to being able to have automated, stable releases.

@erasche

This comment has been minimized.

Copy link
Member

erasche commented Oct 20, 2015

@davebx how goes the release process? :)

@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented Oct 20, 2015

@erasche I've decided to retain sole responsibility for releases until new checklist is complete, I'll do a release now if you wish.

@erasche

This comment has been minimized.

Copy link
Member

erasche commented Oct 20, 2015

@jmchilton oh, okay, sounds good! No, release whenever you feel is appropriate. I imagine many of us (jenkins bot included) are using :master and not too concerned about the public release process. Just wanted to follow up on this :)

@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented Oct 20, 2015

Had an explicit request for an update from @kellrott so pushed 0.18.0.

@peterjc

This comment has been minimized.

Copy link
Contributor

peterjc commented Oct 21, 2015

@erasche I'm using pip install planemo within my .travis.yml setups, rather than working with the master branch - so when I want to use something new I have occasionally waited until an official release came out.

@erasche

This comment has been minimized.

Copy link
Member

erasche commented Oct 21, 2015

@peterjc okay, good to know, thanks for the data point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment