New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on tool id contains a space. #190

Merged
merged 1 commit into from May 9, 2015

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

jmchilton commented May 8, 2015

No description provided.

@peterjc

This comment has been minimized.

Copy link
Contributor

peterjc commented May 8, 2015

+1 pending even stricter guidelines

jmchilton added a commit that referenced this pull request May 9, 2015

Merge pull request #190 from jmchilton/tool_id
Warn on tool id contains a space.

@jmchilton jmchilton merged commit 5c58062 into galaxyproject:master May 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jmchilton jmchilton deleted the jmchilton:tool_id branch May 9, 2015

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented on 5f45987 Jun 12, 2015

According to https://wiki.galaxyproject.org/Admin/Tools/ToolConfigSyntax#A.3Ctool.3E_tag_set , the tool id "should be lowercase and contain only letters, numbers, and underscores". I have no idea how much of this is enforced by Galaxy, so maybe the wiki text can be relaxed or this check tightened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment