New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shed_diff assumed special XML files would be at root #207

Merged
merged 1 commit into from May 14, 2015

Conversation

Projects
None yet
2 participants
@peterjc
Copy link
Contributor

peterjc commented May 14, 2015

Previously planemo shed_diff assumed tool_dependencies.xml and repository_dependencies.xml would be at the root of the Tool Shed tarball when giving them special treatment.

Currently the Tool Shed does not require this, and existing tools may have these XML files in a subfolder.

Fixes GitHub issue #205.

Do not assume special XML files will be at root.
Previously assumed tool_dependencies.xml and repository_dependencies.xml
would be at the root of the Tool Shed tarball when giving them special
treatment in planemo shed_diff.

Currently the Tool Shed does not require this, and existing tools may
have these XML files in a subfolder.

Fixes GitHub issue #205.

@peterjc peterjc force-pushed the peterjc:xml_magic_diff branch from e291335 to 2bc1ebd May 14, 2015

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented May 14, 2015

Thanks a bunch for the fix!

jmchilton added a commit that referenced this pull request May 14, 2015

Merge pull request #207 from peterjc/xml_magic_diff
shed_diff assumed special XML files would be at root

@jmchilton jmchilton merged commit 48dfdee into galaxyproject:master May 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@peterjc peterjc deleted the peterjc:xml_magic_diff branch May 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment