New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint exit code #292

Merged
merged 2 commits into from Sep 10, 2015

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

jmchilton commented Sep 10, 2015

Ping @mvdbeek. xref #281.

marius and others added some commits Aug 13, 2015

marius
Refine exit code behavior for failed tool linting.
This is work started by @mvdbeek with PR #281.

Refinements include:

 - Using an abstract object instead of simple string for indicating tool failure.
 - Extending shed_lint --tools with the failing behavior.
 - Not having other, non-lint uses the tool directory loading register tool errors.*
 - Adds test cases for both shed_lint and lint.

* It may in fact be the case that these should handle this error, but they weren't really checking for the string "error" so I was worried these would just fail with obtuse error messages. This should be revisited down the road I thin.
@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Sep 10, 2015

Very nice, thanks @jmchilton.
This is a lesson about test-driven dev for me!

jmchilton added a commit that referenced this pull request Sep 10, 2015

@jmchilton jmchilton merged commit d33987e into galaxyproject:master Sep 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment