New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Command Option Default Handling #301

Merged
merged 2 commits into from Sep 14, 2015

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

jmchilton commented Sep 14, 2015

  • Use native click abstractions to generate proper default behavior for --test_output, et. al from config file.
  • Add option for specifying host (`--host) on the command-line for all run commands (serve``,``shed_serve``,``tool_factory``).
  • Use new abstraction for click defaults from config file to allow specifying default_port and default_host in ~/.planemo.yml.

Supersedes PR #288.

chambm and others added some commits Sep 2, 2015

Change 127.0.0.1 to 0.0.0.0 to allow serving in docker container.
My docker container doesn't have a GUI. Nor for that matter does my Linux host. So I'm connecting from my Windows box, through a Windows VM, to the Docker container hosting 'planemo serve'. I had to make this change for it to work properly.
Improved default option handling.
 - Use native click abstractons to generate proper default behavior for --test_output, et. al from config file.
 - Add option for specifying host on the command-line for all run commands (serve, shed_serve, tool_factory).
 - Use new abstraction for click defaults from config file to allow specifying default_port and default_host.

jmchilton added a commit that referenced this pull request Sep 14, 2015

Merge pull request #301 from jmchilton/options_2
Improved Command Option Default Handling

@jmchilton jmchilton merged commit 7b9d9d7 into galaxyproject:master Sep 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jmchilton jmchilton deleted the jmchilton:options_2 branch Sep 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment