New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving docker_shell #334

Merged
merged 2 commits into from Oct 20, 2015

Conversation

Projects
None yet
2 participants
@kellrott
Copy link
Contributor

kellrott commented Oct 19, 2015

Adding the '-t' flag to the docker shell command (add psuedo terminal) as well as mounting the tool directory and the current working directory, also setting working directory for docker.

Adding the '-t' flag to the docker shell command (add psuedo terminal…
…) as well as mounting the tool directory and the current working directory.
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Oct 19, 2015

This is seems good, thanks. One question I'm not sure the answer - instead of using the fixed paths should we mount the volumes in specific places instead /working, /tool?

@kellrott

This comment has been minimized.

Copy link
Contributor Author

kellrott commented Oct 19, 2015

I'm mimicking the Galaxy behavior of mounting things to the same path inside the container. But that can be changed. Do you want it that way?

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Oct 20, 2015

This is fine for now, it is simple and you are right - very much the naive approach of Galaxy. Thanks for these enhancements @kellrott they make a lot of sense to me.

jmchilton added a commit that referenced this pull request Oct 20, 2015

@jmchilton jmchilton merged commit 80bd596 into galaxyproject:master Oct 20, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment