/planemo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor toward support for running Galaxy in docker-galaxy-stable. #479

Merged
merged 2 commits into from May 20, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@jmchilton
@jmchilton
Copy link
Member

jmchilton commented May 17, 2016

  • General cleanup of planemo.galaxy.config docstrings and such.
  • Refactor the configured Galaxy properties into ones relevant for Docker and not.
  • Create an interface for the GalaxyConfig object to be very explicit about what the rest of planemo expects from it.
  • Reduce this interface - mainly involves refactoring startup command generation so pid_file doesn't need to be used outside the config module.
  • Implement a BaseGalaxyConfig for GalaxyConfig object functionality that will be shared with a future Docker impementation - and put the local instance specific stuff in a LocalGalaxyConfig object.

xref #15

@jmchilton jmchilton added the enhancement label May 17, 2016

@jmchilton jmchilton force-pushed the jmchilton:docker_galaxy_refactor branch from 2b8bf7b to 8be43ee May 19, 2016

@jmchilton
Refactor toward support for running Galaxy in docker-galaxy-stable. 
 - General cleanup of planemo.galaxy.config docstrings and such.
 - Refactor the configured Galaxy properties into ones relevant for Docker and not.
 - Create an interface for the GalaxyConfig object to be very explicit about what the rest of planemo expects from it.
 - Reduce this interface - mainly involves refactoring startup command generation so pid_file doesn't need to be used outside the config module.
 - Implement a BaseGalaxyConfig for GalaxyConfig object functionality that will be shared with a future Docker impementation - and put the local instance specific stuff in a LocalGalaxyConfig object.
1dcbfec

@jmchilton jmchilton force-pushed the jmchilton:docker_galaxy_refactor branch from 8be43ee to 8121af5 May 20, 2016

@jmchilton
Revise job conf handling. 
 - Tell Galaxy that the webapp's server_name is ``main`` regardless - so that handler's can have fixed ``job_conf.xml`` files.
 - Provide a ``job_conf.xml`` if it isn't specified some other way. This prevents ``galaxy_root`` configuration (this should fix galaxyproject/planemo-machine#61).
 - Add Docker options to Galaxy target commands so job_conf.xml can be configured with Docker options appropriately - enable docker for Galaxy tools with ``--docker``.
Loading status checks…
c4dfd55

@jmchilton jmchilton force-pushed the jmchilton:docker_galaxy_refactor branch from 8121af5 to c4dfd55 May 20, 2016

@jmchilton jmchilton merged commit 1a8db8b into galaxyproject:master May 20, 2016
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment