New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip and setuptools on TravisCI; fix travis_init #521

Merged
merged 2 commits into from Jul 22, 2016

Conversation

Projects
None yet
3 participants
@peterjc
Copy link
Contributor

peterjc commented Jul 22, 2016

Fixes #520 by explicitly updating pip and setuptools before installing planemo.

Also fixes a regression I introduced recently in 364fec2 (typo in function name)

peterjc added some commits Jul 22, 2016

pip install planemo can require recent setuptools
Closes #520 where the dependency chain planemo, cwltool, rdflib,
html5lib failed as that needed setuptools version 18.5 or later.
PEP8 white space; fixed function call
This was a recent mistake of mine, I must not have have
the git pre-commit hook installed on the machine I used
as that caught both points:

planemo/commands/cmd_travis_init.py:49:1: E302 expected 2 blank lines, found 1
planemo/commands/cmd_travis_init.py:81:9: F821 undefined name 'warning'

@peterjc peterjc referenced this pull request Jul 22, 2016

Closed

pip install planemo fail #520

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Jul 22, 2016

Upgrading setuptools should be enough, we had to do the same for tools-iuc TravisCI: galaxyproject/tools-iuc#887

@peterjc

This comment has been minimized.

Copy link
Contributor Author

peterjc commented Jul 22, 2016

Possibly updating setuptools only is enough right now, but I've been bitten by an old pip before with other TravisCI setups, so this seems a sensible precautionary measure.

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Jul 22, 2016

CWL errors again. I think it's fine to merge this.
Thanks @peterjc!

@bgruening bgruening merged commit d0d21e5 into galaxyproject:master Jul 22, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@peterjc peterjc deleted the peterjc:travis_pip_update branch Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment