New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for sha256sum checksums during shed_lint #539

Merged
merged 2 commits into from Aug 17, 2016

Conversation

Projects
None yet
5 participants
@peterjc
Copy link
Contributor

peterjc commented Aug 17, 2016

Looks at the download_by_url and download_file actions only, missing sha256sum is a warning, bad sha256sum is an error (e.g. not 64 characters, or non-hex characters present).

A future --verify switch could download the file and confirm the checksum matches.

TODO: Test case with a bad sha256sum entry (e.g. extra char)

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Aug 17, 2016

The failing test case looks legitimate - I'm fine with this change but devteam and iuc repos are going to start failing Travis checks after we merge this right? @martenson, @nsoranzo, @bgruening, @erasche are we okay with that?

@erasche

This comment has been minimized.

Copy link
Member

erasche commented Aug 17, 2016

👍 I want to know if my downloads are failing hash checks.

Edit: oh, does this fail things with a missing sha256?
Edit2: They're warnings, we test with --fail_level error, so should be fine

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Aug 17, 2016

I did the exact same steps in my brain as @erasche did. 👍

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Aug 17, 2016

👍 for me, we will fix travis if this is the case. Nice change Peter!

@peterjc

This comment has been minimized.

Copy link
Contributor Author

peterjc commented Aug 17, 2016

Copy and paste error in the test cases, one of the checksums is the wrong one...

peterjc added some commits Aug 17, 2016

Look for sha256sum checksums during shed_lint
Looks at the download_by_url and download_file actions only,
missing sha256sum is a warning, bad sha256sum is an error
(e.g. not 64 characters, or non-hex characters present).

A future --verify switch could download the file and confirm
the checksum matches.

@peterjc peterjc force-pushed the peterjc:lint_sha256 branch from f7c60d2 to ea4ba2c Aug 17, 2016

@jmchilton jmchilton merged commit 6755dbe into galaxyproject:master Aug 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Aug 17, 2016

Awesome sauce - thanks! This didn't make the 0.28.0 cut - but it will be 0.29.0. Is there urgency - I can do a release if so?

@peterjc

This comment has been minimized.

Copy link
Contributor Author

peterjc commented Aug 17, 2016

Thanks John - there's no rush from my personal perspective.

@peterjc peterjc deleted the peterjc:lint_sha256 branch Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment