New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 E305 blank lines #606

Merged
merged 4 commits into from Dec 9, 2016

Conversation

Projects
None yet
2 participants
@peterjc
Copy link
Contributor

peterjc commented Dec 8, 2016

Recent changes on the master have broken the TravisCI build, this pull request addresses the new PEP8 blank line violations etc

@peterjc peterjc force-pushed the peterjc:pep8_linting branch from 6c71dd7 to 84c2f46 Dec 8, 2016

peterjc added some commits Dec 8, 2016

PEP8 I201 Missing newline before sections or imports.
The pep8 tool is now stricter about the blocks it expects
imports to be broken up into. This includes local imports.
flake8-import-order linting fix
This error message could have been more useful:

$ flake8 --select I100 planemo/commands/cmd_travis_init.py
planemo/commands/cmd_travis_init.py:9:1: I100 Import statements are in the wrong order. from planemo should be before from planemo

@peterjc peterjc force-pushed the peterjc:pep8_linting branch from 5b57783 to 4e20202 Dec 8, 2016

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Dec 8, 2016

Awesome sauce - thanks a bunch!

@peterjc

This comment has been minimized.

Copy link
Contributor Author

peterjc commented Dec 8, 2016

Travis is happy with the lint checks :)

@peterjc

This comment has been minimized.

Copy link
Contributor Author

peterjc commented Dec 8, 2016

See also flake8-import-order pull request PyCQA/flake8-import-order#98

Use immutable tuples for __all__
This is to address docstring linting warnings from pydocstyle.

Also I am consistently using a multi-line layout even when
there is a single entry, and using double quotes.

Should close issue #607

@jmchilton jmchilton merged commit e863156 into galaxyproject:master Dec 9, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@peterjc peterjc deleted the peterjc:pep8_linting branch Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment