New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint only realized tools during shed linting. #628

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

jmchilton commented Feb 6, 2017

Prevents each tool for being linted for every resolved repository and fixes #564.

Sorry about that.

Lint only realized tools during shed linting.
Prevents each tool for being linted for every resolved repository and fixes #564.

Sorry about that.

@jmchilton jmchilton merged commit abf8838 into galaxyproject:master Feb 6, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@@ -190,7 +196,8 @@ def lint_readme(path, lint_ctx):
lint_ctx.info("README found containing plain text.")


def lint_tool_dependencies_urls(path, lint_ctx):
def lint_tool_dependencies_urls(realized_repository, lint_ctx):
path = realized_repository.real_path

This comment has been minimized.

@bgruening

bgruening Feb 6, 2017

Member

This had broken planemo:

  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/planemo/shed_lint.py", line 200, in lint_tool_dependencies_urls
    path = realized_repository.real_path
AttributeError: 'str' object has no attribute 'real_path'

This comment has been minimized.

@jmchilton

jmchilton Feb 7, 2017

Author Member

No test coverage for --urls it would seem - sorry about that @bgruening.

This comment has been minimized.

@bgruening

bgruening Feb 7, 2017

Member

sorry for not fixing it myself, busy with the training here

jmchilton added a commit that referenced this pull request Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment