New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter_paths() to not partial match paths #665

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

nsoranzo commented Apr 27, 2017

E.g. in galaxyproject/tools-iuc#1278 having 'tools/taxonomy' in .tt_blacklist and executing planemo ci_find_repos --exclude_from .tt_blacklist wrongly filters out also 'tools/taxonomy_krona_chart'.

Fix filter_paths() to not partial match paths
E.g. in galaxyproject/tools-iuc#1278 having
'tools/taxonomy' in `.tt_blacklist` and executing
`planemo ci_find_repos --exclude_from .tt_blacklist` wrongly filters out
also 'tools/taxonomy_krona_chart'.

@nsoranzo nsoranzo referenced this pull request Apr 27, 2017

Merged

Condafy krona #1278

@jmchilton jmchilton merged commit 5ea1ae8 into galaxyproject:master Apr 27, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Apr 27, 2017

Sorry about that - thanks for the fix! I guess I should convert those to regex or globs perhaps.

@nsoranzo

This comment has been minimized.

Copy link
Member Author

nsoranzo commented Apr 27, 2017

Hopefully we'll remove all tools from the blacklist before that is needed :)

@nsoranzo

This comment has been minimized.

Copy link
Member Author

nsoranzo commented May 3, 2017

@jmchilton Can you do a release with this included? It's needed for galaxyproject/tools-iuc#1278 .

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented May 3, 2017

@nsoranzo 0.40.1 is now available on PyPI.

@nsoranzo

This comment has been minimized.

Copy link
Member Author

nsoranzo commented May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment