New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 0 and a warning if repo has no changes #680

Merged
merged 1 commit into from May 26, 2017

Conversation

Projects
None yet
3 participants
@nsoranzo
Copy link
Member

nsoranzo commented May 26, 2017

Fix #494 .

@nsoranzo nsoranzo requested a review from jmchilton May 26, 2017

@erasche erasche merged commit 37e9548 into galaxyproject:master May 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -312,6 +314,10 @@ def upload_repository(ctx, realized_repository, **kwds):
str(repo_id), tar_path, **update_kwds
)
except Exception as e:
if isinstance(e, bioblend.ConnectionError) and e.status_code == 400 and \
e.body == '{"content_alert": "", "err_msg": "No changes to repository."}':

This comment has been minimized.

@martenson

martenson May 26, 2017

Member

I would check only the err_msg here. Content alert has nothing to do with this I think.

This comment has been minimized.

@nsoranzo

nsoranzo May 26, 2017

Author Member

BioBlend returns this ConnectionError exception whose body attribute is the stringified version of the JSON returned by Galaxy. I preferred to be strict to not match other real errors, we can relax this if needed.

@nsoranzo nsoranzo deleted the nsoranzo:fix_494 branch May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment