New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruamel.yaml version #720

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
3 participants
@mvdbeek
Copy link
Member

mvdbeek commented Sep 6, 2017

This should fix #719.

Fix ruamel.yaml version
This should fix #719.
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 6, 2017

Cool - thanks @mvdbeek - I'll work on getting a release out with this in it.

@jmchilton jmchilton merged commit 68266cd into galaxyproject:master Sep 6, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Sep 6, 2017

Shouldn't that be fixed upstream in cwltool?

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 6, 2017

@nsoranzo I imagine it was but we have a fixed older version of cwltool as a dependency, I'll remove this line when I merge my cwltool update as part of #714. Does that sound like the right approach?

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 6, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Sep 6, 2017

Perfect, thanks @jmchilton!

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 6, 2017

@nsoranzo Cool - thanks! I've made that change in #714 and rebased it as d2ea830.

I'm going to see what the tests say about #723 and if things look okay I think I will do a release so this is fixed and Conda is fixed as well. Then I will merge #714 later this week (or maybe later today) and create a new set of problems.

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 6, 2017

Well so things went sideways because the new galaxy-lib introduced test errors (these can be seen in #723 but would be experienced in the wild anyway since we don't pin an upper bound on galaxy-lib). So I just cleaned up and merged my CWL WIP with 2462099 and did a release so either the dependencies are fixed when coming from PyPI ... hopefully ... but probably not and we shall see.

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Sep 6, 2017

@jmchilton I couldn't see any new test error in https://travis-ci.org/galaxyproject/planemo/jobs/272496388:

  • jobloaderctx is caused by using an old cwltool, is fixed by commit 2462099
  • fleeqtk not found: I'm sure I've seen this in previous Travis builds
  • AttributeError: 'module' object has no attribute 'numproc': should be fixed by galaxyproject/galaxy#4565

Am I missing something?

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 6, 2017

I just hadn't seen the jobloaderctx error previously - my 👀 aren't 🦅 (they call me 💩👀). I didn't think it would have occurred with older galaxy-libs before the two I released today.

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Sep 6, 2017

jobloaderctx error is a side-effect of pinning ruamel.yaml in this very PR, in fact it started with https://travis-ci.org/galaxyproject/planemo/jobs/272481174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment