New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: subprocess with universal_newlines=True #764

Merged
merged 1 commit into from Feb 5, 2018

Conversation

Projects
None yet
2 participants
@peterjc
Copy link
Contributor

peterjc commented Feb 5, 2018

This is a simple way to ensure we get a string back (and not bytes) under Python 3, intended to solve #763 where the output is used directly in XML output.

py3: subprocess with universal_newlines=True
This is a simple way to ensure we get a string back
(and not bytes) under Python 3.

@peterjc peterjc requested a review from jmchilton Feb 5, 2018

@jmchilton jmchilton merged commit 4765624 into galaxyproject:master Feb 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Feb 5, 2018

Awesome - thanks for the fix @peterjc !

@peterjc peterjc deleted the peterjc:subprocess_universal_newlines branch Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment