New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use requests.get() when validating http URLs #809

Merged
merged 1 commit into from May 6, 2018

Conversation

Projects
None yet
3 participants
@nsoranzo
Copy link
Member

nsoranzo commented May 1, 2018

Tested on all dirs in https://github.com/TGAC/earlham-galaxytools and 40 dirs in tools-iuc.

Alternative to #808.

@nsoranzo nsoranzo requested a review from bgruening May 1, 2018

@nsoranzo nsoranzo referenced this pull request May 2, 2018

Closed

catch link redirections #808

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented May 3, 2018

Looks good to me!

@bgruening bgruening merged commit 04f74e9 into galaxyproject:master May 6, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented May 6, 2018

Thanks @nsoranzo!

@nsoranzo nsoranzo deleted the nsoranzo:fix_url_linting branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment