/planemo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync galaxy xsd and fix tests #889

Merged
merged 4 commits into from Nov 9, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mvdbeek @nsoranzo @jmchilton
@mvdbeek
Copy link
Member

mvdbeek commented Nov 8, 2018

And test everything under python 3 if in py36 environment. Otherwise we get an old python 2 version from travis.

@mvdbeek mvdbeek force-pushed the mvdbeek:sync_galaxy_xsd branch from f58d8da to 6047d8b Nov 8, 2018

@nsoranzo

This comment has been minimized.

Sign in to view
Copy link
Member

nsoranzo commented Nov 8, 2018

galaxy.xsd is included in galaxy-lib since v18.9.0 , not sure how difficult is to use that one instead.
@nsoranzo

This comment has been minimized.

Sign in to view
Copy link
Member

nsoranzo commented Nov 8, 2018

The os.makedirs errors can be fixed by using galaxy.util.path.safe_makedirs, I'm going to push a commit here soon.
@nsoranzo

This comment has been minimized.

Sign in to view
Copy link
Member

nsoranzo commented Nov 8, 2018

Actually the os.makedirs errors are due to generate_tuto_from_wf test not cleaning after itself when failing, so using safe_makedirs in the other tests may make debugging more confusing, I think.

@jmchilton jmchilton merged commit 811a67a into galaxyproject:master Nov 9, 2018
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment