/planemo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip Galaxy client build for ``planemo serve`` #895

Merged
merged 11 commits into from Nov 24, 2018

Conversation

Reviewers

@jmchilton jmchilton

@mvdbeek mvdbeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nsoranzo @bgruening @jmchilton @mvdbeek
@nsoranzo
Copy link
Member

nsoranzo commented Nov 18, 2018

Fix #845 .

Also, convert an existing gx_repo git repository from bare to mirror before doing a git remote update.

@nsoranzo nsoranzo requested a review from mvdbeek Nov 18, 2018

@nsoranzo nsoranzo changed the title Do not skip client build for planemo serve Do not skip Galaxy client build for ``planemo serve`` Nov 18, 2018

@bgruening

This comment has been minimized.

Sign in to view
Copy link
Member

bgruening commented Nov 18, 2018

I requested an increased max build time from travis, let's see if they grant it.
@jmchilton

jmchilton reviewed Nov 19, 2018
View changes

Show resolved Hide resolved planemo/galaxy/serve.py Outdated

@nsoranzo nsoranzo force-pushed the nsoranzo:serve_rebuild_client branch 3 times, most recently from baddf30 to 0caa8dc Nov 20, 2018

nsoranzo added some commits Nov 18, 2018

@nsoranzo
Do not skip client build for planemo serve 
Fix #845 .
ca009dc
@nsoranzo
Convert an existing gx_repo from bare to mirror 
Follow-up on commit ec16ee7 .
3151023
@nsoranzo
Install Galaxy when the directory specified with ``--galaxy_root` doe… 
…s not exist

or is empty.

Raise an `Exception` if `--galaxy_root` specifies an existing directory and
`--install_galaxy` is set.

Remove unused `_shed_tool_conf()` function and
`FAILED_TO_FIND_GALAXY_EXCEPTION` constant.
0a25da8
@nsoranzo
Run all ServeTestCase tests with the same ``galaxy_root`` directory 
to not rebuild the Galaxy client every time.
e7d4b49
@nsoranzo
Fix broken shell command 
Various tests produced the following error:
```
Set $GALAXY_VIRTUAL_ENV to /home/travis/.planemo/gx_venv
/bin/sh: 1: if [ -e "$GALAXY_VIRTUAL_ENV" ]; : not found
run command exited with return code 127
```

Introduced in commit 434099e .
1397f35
@nsoranzo
Remove unneeded `--galaxy_branch` option in 4 tests 
Fix wrong tool version in workflow.
2fd42de
@nsoranzo
Remove redundant ``os.makerdirs()`` call
e163f44
@nsoranzo
Set ``server_name`` before using it 
Otherwise the `pid_file` is set to the wrong filename, preventing
`LocalGalaxyConfig.kill()` from working when running Galaxy under Python 3.

Follow-up to #874 .
Loading status checks…
e71791c

@nsoranzo nsoranzo force-pushed the nsoranzo:serve_rebuild_client branch from 0caa8dc to e71791c Nov 23, 2018

nsoranzo added some commits Nov 23, 2018

@nsoranzo
Update ``random_lines1`` tool from galaxy repo 
for Python 3 compatibility.
Loading status checks…
01cd291
@nsoranzo
Default host to 127.0.0.1 
Fix the following traceback:

```
Problem serving Galaxy
Traceback (most recent call last):
  File "/home/travis/build/galaxyproject/planemo/planemo/galaxy/serve.py", line 22, in serve
    return _serve(ctx, runnables, **kwds)
  File "/home/travis/build/galaxyproject/planemo/planemo/galaxy/serve.py", line 43, in _serve
    cmd = config.startup_command(ctx, **kwds)
  File "/home/travis/build/galaxyproject/planemo/planemo/galaxy/config.py", line 963, in startup_command
    host=kwds['host'],
KeyError: 'host'
```
Loading status checks…
af4f7c7
@nsoranzo
Pass ``--dev-wheels`` also when serving Galaxy
Loading status checks…
a022c3f
@nsoranzo

This comment has been minimized.

Sign in to view
Copy link
Member Author

nsoranzo commented Nov 23, 2018

Finally green!! 🎉
@mvdbeek

mvdbeek approved these changes Nov 24, 2018
View changes

Copy link
Member

mvdbeek left a comment

Awesome! Thanks a lot @nsoranzo !

@bgruening bgruening merged commit 3ab358e into galaxyproject:master Nov 24, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bgruening

This comment has been minimized.

Sign in to view
Copy link
Member

bgruening commented Nov 24, 2018

Thanks all!

@nsoranzo nsoranzo deleted the nsoranzo:serve_rebuild_client branch Nov 25, 2018

@nsoranzo

This comment has been minimized.

Sign in to view
Copy link
Member Author

nsoranzo commented Nov 25, 2018

Time for a new Planemo release supporting Galaxy 18.09?

@mvdbeek mvdbeek referenced this pull request Dec 30, 2018

Closed

planemo not working with Galaxy 18.09 and OSX? #905

@jmchilton

This comment has been minimized.

Sign in to view
Copy link
Member

jmchilton commented Jan 1, 2019

I let you all down on this - sorry :(. Just released this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment