Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotateMyIDs (several versions) is not really ignoring header line when option set #2319

Closed
jennaj opened this issue Feb 28, 2019 · 9 comments
Closed

Comments

@jennaj
Copy link
Member

@jennaj jennaj commented Feb 28, 2019

Test history usegalaxy.eu: https://usegalaxy.eu:/u/jenj/h/test-hisat2-featurecounts-annotatemyids

Test history usegalaxy.org: https://usegalaxy.org:/u/jen/h/test-hisat2-featurecounts-annotatemyids

If the header is removed first, the tool works fine, across servers and tool versions.

@jennaj
Copy link
Member Author

@jennaj jennaj commented Feb 28, 2019

For reference, this was first reported at Galaxy Help here: https://help.galaxyproject.org/t/annotatemyids-fatal-error/701

Loading

@mblue9
Copy link
Contributor

@mblue9 mblue9 commented Feb 28, 2019

@jennaj it's due to the spaces in the column name ("HISAT on data N"), this should fix it #2320. Actually no, the spaces are causing the issue but the header should be handed better regardless and the fix should do that.

Loading

@jennaj
Copy link
Member Author

@jennaj jennaj commented Mar 1, 2019

@mblue9 Thank you!

Loading

@jennaj
Copy link
Member Author

@jennaj jennaj commented Apr 12, 2019

Looks like this was in the 3/8/19 tool update in the MTS. Only EU appears to have v 3.7.0 installed (yet). But is it really the latest version with this changeset included? GUI has 3.7.0 -- same as MTS -- but the issue doesn't seem to be fixed.

The test fails when the input has a header (single Featurecounts count file, two columns, contains spaces and tabs) + form marked "yes" the input has a header. See dataset 38 in the original test history:

Test history usegalaxy.eu: https://usegalaxy.eu:/u/jenj/h/test-hisat2-featurecounts-annotatemyids

Seems to still be splitting by header whitespace, not tabs, to create labels for data columns, even though sep="\t" is specified. @mblue9 what do you think?

Loading

@mblue9
Copy link
Contributor

@mblue9 mblue9 commented Apr 13, 2019

@jennaj it works fine for me locally with your input file and settings, see screenshot below

Screen Shot 2019-04-13 at 11 41 06 AM

So maybe it just needs to be updated at EU? ping @bgruening

Loading

@bgruening
Copy link
Member

@bgruening bgruening commented Apr 13, 2019

Updated on usegalaxy.eu

Loading

@jennaj
Copy link
Member Author

@jennaj jennaj commented Apr 15, 2019

Great, works now at EU. I'll ping to get ORG updated, too. Going to close this out, thanks all!!

Loading

@jennaj jennaj closed this Apr 15, 2019
@jennaj
Copy link
Member Author

@jennaj jennaj commented Apr 15, 2019

@Slugger70 ping that you will probably want to update the tool at AU as well

Loading

@Slugger70
Copy link
Contributor

@Slugger70 Slugger70 commented Apr 15, 2019

Thanks @jennaj I'm updating tools today so will add the update for this in.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants