New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edgeR: fix for changing FDR method and clarify group naming #2284

Merged
merged 5 commits into from Feb 9, 2019

Conversation

Projects
None yet
3 participants
@mblue9
Copy link
Contributor

mblue9 commented Feb 9, 2019

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)
@@ -1,4 +1,4 @@
<tool id="edger" name="edgeR" version="3.24.1">
<tool id="edger" name="edgeR" version="3.24.1+galaxy1">

This comment has been minimized.

@nsoranzo

nsoranzo Feb 9, 2019

Member

This PR seems to be only fixing a bug so probably no need to increase the version.

This comment has been minimized.

@mblue9

mblue9 Feb 9, 2019

Author Contributor

Ok, have reverted. Wasn't sure to increase it or not as it does affect the outputs (if the FDR method is changed) but yeah it is a bug fix. Thanks @nsoranzo.

@mblue9 mblue9 referenced this pull request Feb 9, 2019

Merged

limma-voom: update to v3.38.3 #2285

1 of 5 tasks complete

@bgruening bgruening merged commit 21f0bc6 into galaxyproject:master Feb 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment